Print WebView: surface main-frame load errors with a toast#365
Open
jim-daf wants to merge 1 commit into
Open
Conversation
The hidden WebView built in printText() drives the print flow via onPageFinished -> createWebPrintJob. The WebViewClient does not override onReceivedError, so if loadData() fails for any reason (very large note that exceeds WebView limits, transient renderer error, etc.) the user gets nothing - no toast, no log, and the print never starts because onPageFinished is also not called. Add onReceivedError on the same anonymous WebViewClient. Guard with request.isForMainFrame so any future sub-resource error does not toast twice, and reuse the existing commons string unknown_error_occurred so the message is already translated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364.
The print flow uses a hidden
WebViewwhoseWebViewClientonly overridesshouldOverrideUrlLoadingandonPageFinished.onPageFinishedis what kicks offcreateWebPrintJob, so if the underlyingloadDatafails (large note, transient renderer error, etc.) the print silently never starts and the user gets no feedback at all.This PR adds
onReceivedErroron the same anonymousWebViewClient:Why this shape:
request.isForMainFrameguards against firing the toast twice if any sub-resource also fails (the WebView is loading text vialoadData, so sub-resources should not really exist, but the guard keeps the override future-proof).org.fossify.commons.R.string.unknown_error_occurredis reused so the message stays already translated. The same string is used elsewhere in this activity fromshowErrorToast, which keeps the failure UX consistent with the rest of the print pipeline.android.webkit.WebResourceError). No new permission, no new resource, no behaviour change on successful prints.